Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish create project layer #1936

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Dec 2, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (Map Style Update, zoom to layer button add)

Related Issue

Describe this PR

This PR contains works to:

  1. Update the style of the create project map to distinguish different layers.
    Where:
  • Default color: task fill-color, building-color
  • Red color: additional features
  • Light blue color: task boundary
  1. Add Zoom To Layer button to submission instance map

Screenshots

image_480
image_720

@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code labels Dec 2, 2024
@spwoodcock
Copy link
Member

Love this! Could the task area be made a lot more transparent though?

Having a strong colour for the stroke is good to distinguish the boundaries, so having such a strong task fill I don't think is needed πŸ˜„

The main thing the user needs to see is the buildings, grouped by some light styling into tasks

@NSUWAL123 NSUWAL123 marked this pull request as ready for review December 3, 2024 10:53
@NSUWAL123 NSUWAL123 requested a review from spwoodcock December 3, 2024 10:53
@spwoodcock spwoodcock merged commit 2800144 into development Dec 3, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the fix/ui-visualization-changes branch December 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants